Return error on out of space #1504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwitt
force-pushed
the
error_outofspace
branch
2 times, most recently
from
29895f0 to
60bc8f2
Compare
Member
|
looks good ! could you add yourself to the AUTHORS file ? |
bwitt
force-pushed
the
error_outofspace
branch
from
60bc8f2 to
90f0a3d
Compare
Author
|
Done! ls the added coverage enough? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1504 +/- ##
==========================================
- Coverage 74.90% 74.48% -0.43%
==========================================
Files 160 160
Lines 18555 18592 +37
==========================================
- Hits 13899 13848 -51
- Misses 3504 3592 +88
Partials 1152 1152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bwitt
force-pushed
the
error_outofspace
branch
2 times, most recently
from
d73c2c8 to
949e41f
Compare
bwitt
force-pushed
the
error_outofspace
branch
from
949e41f to
eac71af
Compare
Member
|
I think there is something wrong. you added tests which actually should cover the changes.. but: patch coverage is 27.90698% and in the diff view the lines are red (needs codeov plugin installed in browser now) ... |
Author
|
Author
|
also it did not error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1474
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Return an error if we run out of disk space. Batch up the sync at the end of writing all files.
Checklist
AUTHORS